[PATCH] D94118: [X86] ESP should not be in the regcall CSR list

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 5 13:48:48 PST 2021


rnk created this revision.
rnk added reviewers: craig.topper, erichkeane.
Herald added subscribers: pengfei, hiraditya.
rnk requested review of this revision.
Herald added a project: LLVM.

All calling conventions should manage ESP explicitly. Typically, they
either preserve it, or use a callee-cleanup convention. There is no need
to push and pop ESP directly. Its inclusion appears to have been an
oversight.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D94118

Files:
  llvm/lib/Target/X86/X86CallingConv.td
  llvm/test/CodeGen/X86/avx512-regcall-Mask.ll
  llvm/test/CodeGen/X86/avx512-regcall-NoMask.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94118.314713.patch
Type: text/x-patch
Size: 10581 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210105/92a232b7/attachment.bin>


More information about the llvm-commits mailing list