[PATCH] D94072: [MC][ELF] Fix accepting abbreviated form with sh_flags and sh_entsize

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 5 11:52:41 PST 2021


MaskRay added a comment.

This now becomes hazy. While `.rodata.cst8` is a built-in section name in MC, it is not in GNU as. i.e. If you specify `.section .rdata.cst8`, GNU as does not make it SHF_MERGE and set sh_entsize to 8.

I think whatever the resolution we take here, you need to fix GCC.

You may need two RUN lines for coverage:

  .ifndef BUILTIN
  .section .rodata.cst8,"aM", at progbits,8
  .endif
  
  .section .rodata.cst8


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94072/new/

https://reviews.llvm.org/D94072



More information about the llvm-commits mailing list