[PATCH] D94053: [Constant] Add containsPoisonElement

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 5 11:25:46 PST 2021


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.



================
Comment at: llvm/lib/IR/Constants.cpp:309
+containsUndefinedElement(const Constant *C,
+                         std::function<bool(const Constant *)> HasFn) {
+  if (auto *VTy = dyn_cast<VectorType>(C->getType())) {
----------------
Prefer `function_ref<>` over `std::function`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94053/new/

https://reviews.llvm.org/D94053



More information about the llvm-commits mailing list