[PATCH] D94040: [WebAssembly] Update basic EH instructions for the new spec

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 5 11:16:19 PST 2021


tlively accepted this revision.
tlively added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrControl.td:154
+               [(set I32:$dst,
+                 (WebAssemblycatch (WebAssemblywrapper texternalsym:$tag)))],
+               "catch   \t$dst, $tag", "catch   \t$tag", 0x07>;
----------------
This isn't totally related to this diff, but do you remember why `WebAssemblywrapper` exists? I don't think I ever had a good grasp on why we need it.


================
Comment at: llvm/test/CodeGen/WebAssembly/eh-labels.mir:37
     successors: %bb.2
     ; CATCH should be after an EH_LABEL at the beginning of an EH pad
     ; CHECK:      EH_LABEL
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94040/new/

https://reviews.llvm.org/D94040



More information about the llvm-commits mailing list