[PATCH] D94102: [AMDGPU] Deduplicate VOP tablegen asm & ins
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 5 11:04:34 PST 2021
foad added a comment.
I don't really follow the details but it looks like quite a nice simplification.
================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.td:1674-1675
+ dag 3pFields = (ins op_sel_hi0:$op_sel_hi, neg_lo0:$neg_lo, neg_hi0:$neg_hi);
+ dag ret = !con(
+ !con(
+ base,
----------------
You can use a single !con with 3 arguments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94102/new/
https://reviews.llvm.org/D94102
More information about the llvm-commits
mailing list