[PATCH] D93883: [WebAssembly] Prototype prefetch instructions

[Thomas Lively via Phabricator via llvm-commits]

tlively added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:318
+  Intrinsic<[], [llvm_ptr_ty],
+            [IntrInaccessibleMemOrArgMemOnly, IntrWillReturn,
+             ReadOnly<ArgIndex<0>>, NoCapture<ArgIndex<0>>],
----------------
aheejin wrote:
> It [[ https://github.com/llvm/llvm-project/blob/5abfeccf10bcbc0d673ece21ddd8d4ac4a0e7594/llvm/include/llvm/IR/Intrinsics.td#L130 | looks ]] `IntrWillReturn` is applied by default?
It looks like this is only true for Intrinsics that inherit `DefaultAttrsIntrinsic`. Otherwise the default-enabled attributes are confusingly disabled by default https://github.com/llvm/llvm-project/blob/5abfeccf10bcbc0d673ece21ddd8d4ac4a0e7594/llvm/include/llvm/IR/Intrinsics.td#L346. As a separate change it would be a good idea to change most of our target intrinsics to use `DefaultAttrsIntrinsics`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93883/new/

https://reviews.llvm.org/D93883