[PATCH] D93778: [test-suite] Support Fortran tests in CMake infrastructure.

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 5 09:41:53 PST 2021


Meinersbur added inline comments.


================
Comment at: CMakeLists.txt:32
+    mark_as_advanced(CLEAR CMAKE_Fortran_COMPILER)
+endif()
 
----------------
jdoerfert wrote:
> Aren't CMAKE variables by convention upper case only?
Weirdly, cmake defines these as `CMAKE_<Lang>_COMPILER`, where <Lang> is `Fortran`, in Pascal case. Also see https://cmake.org/cmake/help/latest/variable/CMAKE_LANG_COMPILER.html and explcitly shown at https://cmake.org/cmake/help/latest/variable/CMAKE_LANG_FLAGS.html.


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93778/new/

https://reviews.llvm.org/D93778



More information about the llvm-commits mailing list