[PATCH] D94065: [NFC] Make remaining cost functions in LoopVectorize.cpp use InstructionCost
    Christopher Tetreault via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Jan  5 09:38:42 PST 2021
    
    
  
ctetreau added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:7267
+             "Invalid vector call or intrinsic cost");
+      return InstructionCost::min(CallCost, IntrinsicCost);
+    }
----------------
I mentioned it in another patch, but I'm wondering if InstructionCost::min is a neccesary function. I think std::min will work.
Should we get rid of InstructionCost::min and InstructionCost::max?
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94065/new/
https://reviews.llvm.org/D94065
    
    
More information about the llvm-commits
mailing list