[PATCH] D89490: Introduce __attribute__((darwin_abi))

[Aaron Ballman via Phabricator via llvm-commits]

aaron.ballman added a comment.

The frontend parts LGTM, but you should wait for someone else to review the backend parts before landing.



================
Comment at: clang/test/Sema/callingconv-darwin_abi.c:10
+
+void(__attribute__((darwin_abi)) * pfoo2)(void) = foo; // expected-warning{{incompatible function pointer types}}
----------------
aguinet wrote:
> aaron.ballman wrote:
> > You should also add some tests like:
> > ```
> > __attribute__((darwin_abi)) int i; // error
> > __attribute__((darwin_abi(12))) void func(void); // error
> > ```
> If I am correct, this is tested in `clang/test/Sema/darwin_abi-sysv_abi.c`
So it is! Sorry for the noise. :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89490/new/

https://reviews.llvm.org/D89490