[PATCH] D91834: [SelectionDAG] Use TypeSize for the stack offset.
Hsiangkai Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 5 06:53:05 PST 2021
HsiangKai added a comment.
In D91834#2478933 <https://reviews.llvm.org/D91834#2478933>, @paulwalker-arm wrote:
> As before I still believe there should be a test to protect this fix as presumably you're doing it for a reason.
I agree. I encountered the bug when implementing some vector instructions in the downstream. Currently, we are changing the way to implement these vector instructions. We could not trigger it any more under the new implementation. So, I have no idea how to create the test case now. I will not land this commit until I could find a way to test it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91834/new/
https://reviews.llvm.org/D91834
More information about the llvm-commits
mailing list