[PATCH] D93662: [SimplifyCFG] Keep !dgb metadata of moved instruction, if they match.

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

This improvement looks good and preserves more source locations. Awkwardly, as @vsk says it's quite different from the other documented rules, because it relies on the context of where the instructions are going to be placed.

In terms of wording, how about adding an additional clause:

  A transformation should preserve the debug location of an instruction [...] if the destination block already contains an instruction with an identical debug location

Which is slightly broader than your wording @fhahn, but IMHO gets across the idea that the location shouldn't be preserved if it's "new" to a block. Opinions?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93662/new/

https://reviews.llvm.org/D93662