[PATCH] D94085: [simd_ops] Build tests with -fpic

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard created this revision.
ostannard added reviewers: MaskRay, asbirlea.
Herald added a subscriber: mgorny.
ostannard requested review of this revision.
Herald added a project: LLVM.

Since https://reviews.llvm.org/rG2047c10c22b0, the dso_local specifier
must be included in IR when building non-PIC code. The bitcode files in
this test suite do not have this, so will only work when all of the code
is built with -fpic.

The alternative to this would be to re-generate the bitcode with the
dso_local specifier where needed, but I don't know how this code was
generated in the first place, and don't want to modify the bitcode files
in-place if they might be later re-generated.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D94085

Files:
  Bitcode/simd_ops/CMakeLists.txt


Index: Bitcode/simd_ops/CMakeLists.txt
===================================================================
--- Bitcode/simd_ops/CMakeLists.txt
+++ Bitcode/simd_ops/CMakeLists.txt
@@ -25,4 +25,5 @@
     ${CMAKE_CURRENT_SOURCE_DIR}/${ARCH}_scalar_tests/scalar_${namebc}.bc
   )
   target_link_libraries(simd_ops_${namebc} simd_ops)
+  set_property(TARGET simd_ops_${namebc} PROPERTY POSITION_INDEPENDENT_CODE ON)
 endforeach()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94085.314588.patch
Type: text/x-patch
Size: 425 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210105/228f83fd/attachment.bin>