[PATCH] D92129: [VPlan] Keep start value in VPWidenIntOrFpInductionRecipe (NFC).

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 5 06:13:48 PST 2021


fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8695
   assert(!State.Instance && "Int or FP induction being replicated.");
-  State.ILV->widenIntOrFpInduction(IV, Trunc);
+  State.ILV->widenIntOrFpInduction(IV, getStartValue()->getOutOfScopeIRValue(),
+                                   Trunc);
----------------
Ayal wrote:
> getStateValue() can be asserted to be a live-in, i.e., have a null Def, and then we can obtain its underlying Value (the latter possibly asserted to be non null)?
I updated D92281 to include such an assertion in `getLiveInIRValue`. There will be multiple users, so I think it would make sense to keep the simple helper, but I can also remove it if you think that's preferable.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92129/new/

https://reviews.llvm.org/D92129



More information about the llvm-commits mailing list