[PATCH] D93759: [VE] Expand single-element BUILD_VECTOR to INSERT_VECTOR_ELT

Tue Jan 5 06:09:09 PST 2021

simoll added inline comments.

================
Comment at: llvm/test/CodeGen/VE/Vector/expand_single_elem_build_vec.ll:2
+; REQUIRES: asserts
+; RUN: not --crash llc %s -march=ve -mattr=+vpu -o /dev/null |& FileCheck %s
+
----------------
kaz7 wrote:
> `|&` works only with bash.  For example, this test won't work on MacOS.  Please use `2>&1 | ` style.
> 
> On the other hand, D93687 has been merged.  So I guess this it is posisble to implement this test much simply using `LSV` instructions.
It's a chicken-egg problem.. i doubt anybody will build LLVM with VE on a MacOS system.. will fix this regardless, rebase the insert/extract element patch and update this test in a followup patch

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93759/new/

https://reviews.llvm.org/D93759