[PATCH] D93687: [VE] Extract & insert vector element isel

[Simon Moll via Phabricator via llvm-commits]

simoll added inline comments.


================
Comment at: llvm/lib/Target/VE/VEISelLowering.cpp:293
 #include "VVPNodes.def"
+
+    setOperationAction(ISD::INSERT_VECTOR_ELT, LegalVecVT, Legal);
----------------
kaz7 wrote:
> simoll wrote:
> > kaz7 wrote:
> > > The definition of BUILD_VECTOR action and other INSERT_VECTOR_ELT/EXTRACT_VECTOR_ELT actions are separated by VVP actions.
> > You mean that the `setOperationAction` calls for VVP are not at the top or bottom of the `initVPUActions` function?
> > If i understand correctly, why does it matter?
> Yes.  If you have a certain reason to do that, it's fine.  But, at least, I would like to understand it since I may change codes also.  If you are doing without any reason, I would like to ask you to organize changes in maybe next patch.
Ok. This is now structured as follows:
The first loop iterates over all non-packed VTs, VVP actions come last in that loop.
The second loop iterates over all packed VTs..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93687/new/

https://reviews.llvm.org/D93687