[PATCH] D94035: [RISCV] Don't parse 'vmsltu.vi v0, v1, 0' as 'vmsleu.vi v0, v1, -1'

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 5 02:15:07 PST 2021


craig.topper added a comment.

In D94035#2478822 <https://reviews.llvm.org/D94035#2478822>, @frasercrmck wrote:

> LGTM too, but pardon my ignorance: I thought we could match an explicit immediate in `InstAlias`es? Or is it that we can't do the decrement? I'm only going by matching `vxor -1` as `vnot` but that's how I interpret the word "match".

You can match an explicit immediate in the MCInst part of the alias. You can’t match an immediate in the text part. It ends up telling the parser to look for a string token containg “0”, but the lexer would never generate that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94035/new/

https://reviews.llvm.org/D94035



More information about the llvm-commits mailing list