[PATCH] D93858: [obj2yaml,yaml2obj] - Refine how we set/dump the sh_entsize field.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Could you explain why this patch fixes the ARM_EXIDX sh_entsize specifically? I don't see anything immediately that would only fix that section (and not other sections).



================
Comment at: llvm/test/tools/obj2yaml/ELF/mips-abi-flags.yaml:54-55
 # MIPS-NEXT:   Type: SHT_MIPS_ABIFLAGS
+## We don't print the "EntSize" key, because 0x18 is the default value
+## for the sh_entsize field of SHT_MIPS_ABIFLAGS.
 # MIPS-NEXT:   ISA:  0x0
----------------
Do you think this deserves a case where the entsize is not default?


================
Comment at: llvm/test/tools/obj2yaml/ELF/sht-symtab-shndx.yaml:191
+## sh_entsize has an unexpected value (not equal to 4).
+## Check we don't print the "EntSize" field when the "sh_entsize" field has the default value.
+
----------------
Really, this comment has nothing to do with the first RUN below it. Probably you should move it to the ENTSIZE=4 case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93858/new/

https://reviews.llvm.org/D93858