[PATCH] D93937: [PowerPC] [NFC] Remove dead code in BUILD_VECTOR peephole

Qiu Chaofan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 4 19:30:38 PST 2021


qiucf marked an inline comment as done.
qiucf added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:9583
     // t = vsplti c, result = vsldoi t, t, 3
     if (SextVal == (int)(((unsigned)i << 24) | (i < 0 ? 0xFFFFFF : 0))) {
       SDValue T = getCanonicalConstSplat(i, SplatSize, MVT::v16i8, DAG, dl);
----------------
RKSimon wrote:
> Have you been able to look at these at all? PR47942 mentions that we have no code coverage for the vsldoi 2/3 cases
Committed rG48340fbe to cover the two cases.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93937/new/

https://reviews.llvm.org/D93937



More information about the llvm-commits mailing list