lxfind created this revision.
lxfind added reviewers: chandlerc, MaskRay, aeubanks.
Herald added subscribers: hoy, modimo, wenlei, hiraditya.
lxfind requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
This function no longer does anything useful. It probably did something originally but latter changes removed them and didn't clean up this function.
The checks are already done in the callers as well.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D94055
Files:
llvm/include/llvm/Analysis/LazyCallGraph.h
llvm/lib/Analysis/LazyCallGraph.cpp
Index: llvm/lib/Analysis/LazyCallGraph.cpp
===================================================================
--- llvm/lib/Analysis/LazyCallGraph.cpp
+++ llvm/lib/Analysis/LazyCallGraph.cpp
@@ -1373,23 +1373,6 @@
return Result;
}
-void LazyCallGraph::RefSCC::handleTrivialEdgeInsertion(Node &SourceN,
- Node &TargetN) {
- // The only trivial case that requires any graph updates is when we add new
- // ref edge and may connect different RefSCCs along that path. This is only
- // because of the parents set. Every other part of the graph remains constant
- // after this edge insertion.
- assert(G->lookupRefSCC(SourceN) == this && "Source must be in this RefSCC.");
- RefSCC &TargetRC = *G->lookupRefSCC(TargetN);
- if (&TargetRC == this)
- return;
-
-#ifdef EXPENSIVE_CHECKS
- assert(TargetRC.isDescendantOf(*this) &&
- "Target must be a descendant of the Source.");
-#endif
-}
-
void LazyCallGraph::RefSCC::insertTrivialCallEdge(Node &SourceN,
Node &TargetN) {
#ifndef NDEBUG
@@ -1420,9 +1403,6 @@
// Create the new edge.
SourceN->Edges.emplace_back(TargetN, Edge::Call);
}
-
- // Now that we have the edge, handle the graph fallout.
- handleTrivialEdgeInsertion(SourceN, TargetN);
}
void LazyCallGraph::RefSCC::insertTrivialRefEdge(Node &SourceN, Node &TargetN) {
@@ -1449,9 +1429,6 @@
// Create the new edge.
SourceN->Edges.emplace_back(TargetN, Edge::Ref);
-
- // Now that we have the edge, handle the graph fallout.
- handleTrivialEdgeInsertion(SourceN, TargetN);
}
void LazyCallGraph::RefSCC::replaceNodeFunction(Node &N, Function &NewF) {
Index: llvm/include/llvm/Analysis/LazyCallGraph.h
===================================================================
--- llvm/include/llvm/Analysis/LazyCallGraph.h
+++ llvm/include/llvm/Analysis/LazyCallGraph.h
@@ -598,10 +598,6 @@
void verify();
#endif
- /// Handle any necessary parent set updates after inserting a trivial ref
- /// or call edge.
- void handleTrivialEdgeInsertion(Node &SourceN, Node &TargetN);
-
public:
using iterator = pointee_iterator<SmallVectorImpl<SCC *>::const_iterator>;
using range = iterator_range<iterator>;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94055.314490.patch
Type: text/x-patch
Size: 2286 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210105/329aaca0/attachment.bin>