[PATCH] D94054: [PowerPC] Try to fold sqrt/sdiv test results with the branch.

Qing Shan Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 4 18:44:21 PST 2021


steven.zhang added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:4384
 
+static unsigned getTestSqrtOpcode(SDValue N) {
+  if (N.getOpcode() == PPCISD::FTSQRT) {
----------------
Do you have any problems to implement this folding with .td ? It doesn't make sense to me to get the opcode and then do the folding, as that is done during instr match(.td).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94054/new/

https://reviews.llvm.org/D94054



More information about the llvm-commits mailing list