[PATCH] D92065: [flang][openacc] Lower parallel loop combined construct
Eric Schweitz via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 4 17:04:58 PST 2021
schweitz accepted this revision.
schweitz added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: flang/lib/Lower/OpenACC.cpp:615
+ } else {
+ llvm::report_fatal_error(
+ "Unknown combined construct encountered in lowering");
----------------
When we get the green-light to upstream, you may want to consider using `fir::emitFatalError()` here, as it will take `mlir::Location` information and produce a bit nicer output.
(On the other hand, the error seems like a general "this can never happen", but this was a chance to add a gratuitous plug.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92065/new/
https://reviews.llvm.org/D92065
More information about the llvm-commits
mailing list