[PATCH] D93812: [RISCV] Handle stack rounding only in RISCVFrameLowering.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 4 15:54:57 PST 2021


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:246
+  // MaxCallFrameSize is defined through ADJCALLSTACKDOWN.
+  // Reserve frame space for out going arguments of caller.
+  if (MFI.adjustsStack() && hasReservedCallFrame(MF))
----------------
"out going" -> outgoing


================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.h:68
 
+  /// targetHandlesStackFrameRounding - Returns true if the target is
+  /// responsible for rounding up the stack frame (probably at emitPrologue
----------------
No need to write the function name in the doxygen comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93812/new/

https://reviews.llvm.org/D93812



More information about the llvm-commits mailing list