[PATCH] D89490: Introduce __attribute__((darwin_abi))

[Aaron Ballman via Phabricator via llvm-commits]

aaron.ballman added a comment.

Some minor nits while double-checking the attribute bits.



================
Comment at: clang/include/clang/Basic/AttrDocs.td:2334
+
+Here is the list of whatthis attribute supports, quoting the aformentioned
+document:
----------------



================
Comment at: clang/test/CodeGen/darwin_abi.c:1
+// RUN: %clang_cc1 -triple aarch64-pc-linux %s -emit-llvm -o - |FileCheck %s
+// Checks that correct LLVM IR is generated for functions that target
----------------



================
Comment at: clang/test/CodeGen/darwin_abi_empty_structs.cpp:4
+// empty structures unless those structures have a nontrivial destructor or
+// copy constructor." when using darwin_abi
+
----------------



================
Comment at: clang/test/CodeGen/darwin_abi_vaarg.c:1
+// RUN: %clang_cc1 -triple aarch64-pc-linux -emit-llvm %s -o - |FileCheck %s
+// Check that va_arg used inside a function with the darwin_abi attribute still
----------------



================
Comment at: clang/test/Sema/callingconv-darwin_abi.c:10
+
+void(__attribute__((darwin_abi)) * pfoo2)(void) = foo; // expected-warning{{incompatible function pointer types}}
----------------
You should also add some tests like:
```
__attribute__((darwin_abi)) int i; // error
__attribute__((darwin_abi(12))) void func(void); // error
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89490/new/

https://reviews.llvm.org/D89490