[PATCH] D93510: Fix llvm::Optional build breaks in MSVC using std::is_trivially_copyable

James Player via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 4 12:12:21 PST 2021


jplayer-nv updated this revision to Diff 314429.
jplayer-nv added a comment.

1. Expanded the check for the trivial specialization of `OptionalStorage`
2. Formatted the `OptionalStorage` template list.
3. Added a test to ensure that deleting move constructor / assignment will still choose the trivial `OptionalStorage` specialization.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93510/new/

https://reviews.llvm.org/D93510

Files:
  llvm/include/llvm/ADT/Optional.h
  llvm/unittests/ADT/OptionalTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93510.314429.patch
Type: text/x-patch
Size: 4823 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210104/55d12d10/attachment.bin>


More information about the llvm-commits mailing list