[PATCH] D93891: [DAGCombine] Remove the check for unsafe-fp-math when we are checking the AFN

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 4 11:11:20 PST 2021


arsenm added a comment.

In D93891#2473825 <https://reviews.llvm.org/D93891#2473825>, @spatel wrote:

> We're trying to (very slowly...) move away from needing the global/target options. Also, I'm not sure how those translate with GlobalISel.
> If there's a real-world case where the target options do not match the fast-math-flags on the IR, we should investigate if that was unexpected. Otherwise, I would prefer that we not add to the uses of target options.

It does make a difference in a few contexts where we don't have flags (e.g. function arguments)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93891/new/

https://reviews.llvm.org/D93891



More information about the llvm-commits mailing list