[PATCH] D92523: Small improvements to Intrinsic::getName

Erich Keane via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 4 10:16:01 PST 2021


erichkeane added a comment.

I note here: https://llvm.org/doxygen/namespacellvm_1_1Intrinsic.html#a7157f9fa9dd11f234ec3c58517cb6d96 that the documentatoin to the getName function variant says:

"If no overloads are requried, it is safe to use this version, but better to use the StringRef version."

It seems that this assert isn't consistent with the documentation on the function.  I believe one of the two needs to be fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92523/new/

https://reviews.llvm.org/D92523



More information about the llvm-commits mailing list