[PATCH] D91718: [LV] Legalize scalable VF hints

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 4 06:42:45 PST 2021


sdesmalen added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:5600-5601
+      Optional<unsigned> MaxVScale = TTI.getMaxVScale();
+      assert(MaxVScale &&
+             "max vscale undefined for target that supports scalable vectors!");
+
----------------
It should be fine for MaxVScale to be undefined for a target architecture. Based on the logic below where it tries to pick a suitable alternative VF, it should probably pick a different (non-scalable) VF, instead of crashing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91718/new/

https://reviews.llvm.org/D91718



More information about the llvm-commits mailing list