[PATCH] D83495: [DebugInfo] Add DWARF emission for DBG_VALUE_LIST

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:2469
+    } else if (Entry.isConstantFP()) {
+	  if (AP.getDwarfVersion() >= 4 && AP.getDwarfDebug()->tuneForGDB()) {
+		  DwarfExpr.addConstantFP(Entry.getConstantFP()->getValueAPF(), AP);
----------------
scott.linder wrote:
> Was changing this condition intentional? If so can it be in a separate patch?
Unintentional, the change here got missed during a rebase (but is fixed in my local copy, which I'll push up shortly).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83495/new/

https://reviews.llvm.org/D83495