[PATCH] D93811: [VE] Support llvm.eh.sjlj.lsda

[Simon Moll via Phabricator via llvm-commits]

simoll added inline comments.


================
Comment at: llvm/lib/Target/VE/VEISelLowering.cpp:1550
+    const TargetLowering &TLI = DAG.getTargetLoweringInfo();
+    MVT PtrVT = TLI.getPointerTy(DAG.getDataLayout());
+    const VETargetMachine *TM =
----------------
kaz7 wrote:
> simoll wrote:
> > I suppose you could re-use the type of `Op` here
> I'm not sure about it.  Do you have any strategies to decide either Op.getValueType() or TLI.getPointerTy()?  All other architectures use TLI.getPointerTy() to implement lsda.  It's really difficult to decide it with certain reasons.
When isel calls `LowerOperation`, all types are MVTs because all EVTs have been legalized. `Op.getValueType()` should give you the exact same MVT as `TLI.getPointerTy()`.
AFAIK only `LowerOperationWrapper` is where you have to be careful about operand EVTs but we are not using this in upstream (yet).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93811/new/

https://reviews.llvm.org/D93811