[PATCH] D93836: [VE] Change default CPU name to "generic"

Kazushi Marukawa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 4 02:12:15 PST 2021


kaz7 updated this revision to Diff 314336.
kaz7 added a comment.

Update following suggestions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93836/new/

https://reviews.llvm.org/D93836

Files:
  llvm/lib/Target/VE/MCTargetDesc/VEMCTargetDesc.cpp
  llvm/lib/Target/VE/VE.td
  llvm/lib/Target/VE/VESubtarget.cpp
  llvm/test/CodeGen/VE/Scalar/cpu.ll


Index: llvm/test/CodeGen/VE/Scalar/cpu.ll
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/VE/Scalar/cpu.ll
@@ -0,0 +1,5 @@
+; RUN: llc -mtriple=ve -mcpu=help < %s 2>&1 | FileCheck %s
+
+; CHECK: Available CPUs for this target:
+; CHECK-EMPTY:
+; CHECK-NEXT: generic - Select the generic processor.
Index: llvm/lib/Target/VE/VESubtarget.cpp
===================================================================
--- llvm/lib/Target/VE/VESubtarget.cpp
+++ llvm/lib/Target/VE/VESubtarget.cpp
@@ -33,7 +33,7 @@
   // Determine default and user specified characteristics
   std::string CPUName = std::string(CPU);
   if (CPUName.empty())
-    CPUName = "ve";
+    CPUName = "generic";
 
   // Parse features string.
   ParseSubtargetFeatures(CPUName, /*TuneCPU=*/CPU, FS);
Index: llvm/lib/Target/VE/VE.td
===================================================================
--- llvm/lib/Target/VE/VE.td
+++ llvm/lib/Target/VE/VE.td
@@ -46,7 +46,7 @@
 class Proc<string Name, list<SubtargetFeature> Features>
  : Processor<Name, NoItineraries, Features>;
 
-def : Proc<"ve",             []>;
+def : Proc<"generic", []>;
 
 //===----------------------------------------------------------------------===//
 // Declare the target which we are implementing
Index: llvm/lib/Target/VE/MCTargetDesc/VEMCTargetDesc.cpp
===================================================================
--- llvm/lib/Target/VE/MCTargetDesc/VEMCTargetDesc.cpp
+++ llvm/lib/Target/VE/MCTargetDesc/VEMCTargetDesc.cpp
@@ -56,7 +56,7 @@
 static MCSubtargetInfo *createVEMCSubtargetInfo(const Triple &TT, StringRef CPU,
                                                 StringRef FS) {
   if (CPU.empty())
-    CPU = "ve";
+    CPU = "generic";
   return createVEMCSubtargetInfoImpl(TT, CPU, /*TuneCPU=*/CPU, FS);
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93836.314336.patch
Type: text/x-patch
Size: 1833 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210104/bd837935/attachment.bin>


More information about the llvm-commits mailing list