[PATCH] D93617: [LoopVectorize] Take non-instruction's size into consideration when computing leader's demanded bits

guopeilin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 4 01:32:37 PST 2021


guopeilin added inline comments.


================
Comment at: llvm/lib/Analysis/VectorUtils.cpp:541
+        continue;
+      uint64_t BitSize = Val->getType()->getScalarSizeInBits();
+      if (BitSize == 0)
----------------
nikic wrote:
> You should use `DL.getTypeSizeInBits(Val->getType()` here, which will remove the need for the `== 0` check.
Ok, and I use Argument->getParent()->getParent()->getDataLayout() to get the DataLayout.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93617/new/

https://reviews.llvm.org/D93617



More information about the llvm-commits mailing list