[PATCH] D93697: [obj2yaml] - Don't crash when an object has an empty symbol table.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 4 01:22:31 PST 2021


jhenderson added inline comments.


================
Comment at: llvm/tools/obj2yaml/elf2yaml.cpp:230
+  // We also dump symbol tables when the Size field is set. It happens when they
+  // are empty, what normally should not happen.
   if (S.Type == ELF::SHT_STRTAB || S.Type == ELF::SHT_SYMTAB ||
----------------
MaskRay wrote:
> It happens with the non-conforming empty case.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93697/new/

https://reviews.llvm.org/D93697



More information about the llvm-commits mailing list