[PATCH] D93997: [InterleavedAccess] Return correct 'modified' status.

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 4 01:08:26 PST 2021


SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/CodeGen/InterleavedAccessPass.cpp:381
+    // BinOpShuffles is not empty, replaceBinOpShuffles made changes.
+    return !Extracts.empty() || !BinOpShuffles.empty();
+  }
----------------
Bit of a nitpick, but would it make sense to do the `return !BinOpShuffles.empty()` in `replaceBinOpShuffles`? Letting that function return a bool is probably more consistent? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93997/new/

https://reviews.llvm.org/D93997



More information about the llvm-commits mailing list