[PATCH] D93898: [X86] Fix tile register spill issue.

Wei Xiao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 3 19:20:36 PST 2021


wxiao3 added inline comments.


================
Comment at: llvm/lib/CodeGen/InlineSpiller.cpp:272
 
+static void getInterval(const MachineInstr &MI, LiveIntervals &LIS) {
+  for (unsigned I = 0, E = MI.getNumOperands(); I != E; ++I) {
----------------
The function name is misleading since the function just get intervals for definition registers.
Suggest using more specific name such as "getVDefInterval" or something else.

BTW, I guess there may be existing code can provide similar functionality of creating intervals for new registers.
@qcolombet may provide more information.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93898/new/

https://reviews.llvm.org/D93898



More information about the llvm-commits mailing list