[PATCH] D93662: [SimplifyCFG] Keep !dgb metadata of moved instruction, if they match.

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 3 17:06:12 PST 2021


vsk added a comment.

In its current form, the rule for preserving debug locs doesn't seem to apply here (https://llvm.org/docs/HowToUpdateDebugInfo.html#when-to-preserve-an-instruction-location). Imho we ought to revise the guidance there before proceeding with this patch (e.g. by adding some carveout for when the destination debug loc is the same). If you can share, it might also help to have a little context - unless there's some intervening optimization, the dwarf generator's location cascade should kick in in this situation?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93662/new/

https://reviews.llvm.org/D93662



More information about the llvm-commits mailing list