[PATCH] D93906: [LoopDeletion] Break backedge of loops when known not taken
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jan 3 12:11:59 PST 2021
fhahn added inline comments.
================
Comment at: llvm/lib/Transforms/Utils/LoopUtils.cpp:774
+
+ std::unique_ptr<MemorySSAUpdater> MSSAU;
+ if (MSSA)
----------------
I realize this is similar to what is done in `deleteDeadLoop`, but MSSA is only passed so it can be kept up-to-date, right? Can we just pass a pointer to the updater instead (making the intended use more explicit and avoids a dynamic allocation here)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93906/new/
https://reviews.llvm.org/D93906
More information about the llvm-commits
mailing list