[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

Sat Jan 2 08:51:54 PST 2021

nlopes added a comment.

In D87188#2476230 <https://reviews.llvm.org/D87188#2476230>, @thakis wrote:

> In D87188#2470401 <https://reviews.llvm.org/D87188#2470401>, @lebedev.ri wrote:
>
>> In D87188#2470392 <https://reviews.llvm.org/D87188#2470392>, @thakis wrote:
>>
>>> Heads up: Breaks a test for us: https://bugs.chromium.org/p/chromium/issues/detail?id=1161542
>>>
>>> (No reduced repro yet, might be UB, just fyi at this point.)
>>
>> Thanks for headsup. For now i'll deal with the problem @nlopes pointed out above in a bit..
>
> Just to follow up, this ended up being UB on our end (fix: https://android-review.googlesource.com/c/platform/external/perfetto/+/1535483)

Nice! 😀  Thanks for the update.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87188/new/

https://reviews.llvm.org/D87188