[PATCH] D91334: [compiler-rt] Set CMAKE_TRY_COMPILE_TARGET_TYPE to STATIC_LIBRARY when building builtins standalone

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 2 08:45:24 PST 2021


luismarques added subscribers: abidh, luismarques.
luismarques added a comment.

Based on your description and rationale I *think* this makes sense and should be safe. I'll leave it to others to explicitly approve the patch, though.

@abidh has a presentation where he was manually setting this to the same value for building a pure LLVM toolchain, for the same reasons. I suppose the advantage of patching the CMake file is that this issue will be taken care of automatically, and that perhaps it wouldn't be convenient, obvious or possible to manually set this when building Compiler-RT as part of an integrated LLVM build (`LLVM_ENABLE_RUNTIMES/PROJECTS`)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91334/new/

https://reviews.llvm.org/D91334



More information about the llvm-commits mailing list