[PATCH] D87302: [IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions.

[Andrew Litteken via Phabricator via llvm-commits]

AndrewLitteken added a comment.

In D87302#2277131 <https://reviews.llvm.org/D87302#2277131>, @vsk wrote:

> CodeExtractor contains a utility to fix up debug info after extraction occurs (I believe it's called `fixupDebugInfoPostExtraction`). It's solving the same problem - is there any way to generalize/reuse that logic?

I believe it already uses it since the CodeExtractor is used to create the new functions in each case, but this is mainly for the function that moves them all together.  The problem is that  `fixupDebugInfoPostExtraction` transfers the information from the original function, which would not be correct in this case since we are merging the information from several different code locations into one.  This also addresses @jroelofs disappointment, but since I'm not aware of any mechanism to say that one particular line in IR is from two different source code locations, I think it has to be dropped altogether for correctness.

Right now the current mechanism in lldb is simply skipping over the section of code, which isn't ideal, but it is consistent.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87302/new/

https://reviews.llvm.org/D87302