[PATCH] D88356: [ConstantRange] Make exhaustive testing more principled (NFC)

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 1 08:35:36 PST 2021


nikic added a reviewer: lebedev.ri.
nikic added a subscriber: lebedev.ri.
nikic added a comment.

@lebedev.ri Any thoughts on this testing approach relative to what we do currently and your proposal at D88283 <https://reviews.llvm.org/D88283>? I thought this was quite nice in how it brings everything under one umbrella, including cases we could not test before (add, sub) or only with a lot of effort (testBinarySetOperationExhaustive), but I'm not sure it addresses your concerns.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88356/new/

https://reviews.llvm.org/D88356



More information about the llvm-commits mailing list