[PATCH] D93820: [InstSimplify] Don't fold gep p, -p to null
Simonas Kazlauskas via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 31 17:00:13 PST 2020
nagisa added a comment.
Why is discussion about `gepi` coming up at all?
This differential, from its description is all about a regular `gep`, which is currently mis-optimized according to Alive itself <https://alive2.llvm.org/ce/z/TwXAQX>. Sure there has been collateral damage from fixing handling of `gep`, but I think we all agree having a working `gep` is more important than a very efficient `gepi`?
(If the fold turns out to be actually valid for `gepi`, it can be added back just for `gepi`…)
The only thing missing in this diff from what I can tell is just a regression test…
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93820/new/
https://reviews.llvm.org/D93820
More information about the llvm-commits
mailing list