[PATCH] D93943: [SimplifyCFG] Update SimplifyBranchOnICmpChain to recognize select form of and/or

[Juneyoung Lee via Phabricator via llvm-commits]

aqjune added a comment.

In D93943#2475598 <https://reviews.llvm.org/D93943#2475598>, @nikic wrote:

> I think this may not be correct if there is an `ExtraCase`. `ExtraCase || X == C || ...` should be fine as it is converted into `if (!ExtraCase) goto; switch (X)`, but something like `... || X == C || ExtraCase` would not be fine.

You're right. Actually, while updating test/Transforms/SimplifyCFG/switch_create.ll I realized this and maybe I wanted to think that it wasn't very important, *but* that's not the right direction. I'll update this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93943/new/

https://reviews.llvm.org/D93943