[PATCH] D93957: Revert "[ThinLTO][test] Add visibility related tests"

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 31 10:11:36 PST 2020


lebedev.ri added a comment.

In D93957#2475760 <https://reviews.llvm.org/D93957#2475760>, @bgraur wrote:

> The descritption is: "Both newly added tests fail in Release."
>
> That means:
> 1/ Build llvm in Release configuration.
> 2/ Execute the tests and they will fail.



> Checking any build bots won't show any failure because the problem is a test failure, not a build breakage.

Are you suggesting that buildbots don't actually run tests?

In D93957#2475760 <https://reviews.llvm.org/D93957#2475760>, @bgraur wrote:

> The descritption is: "Both newly added tests fail in Release."
>
> That means:
> 1/ Build llvm in Release configuration.
> 2/ Execute the tests and they will fail.
>
> Checking any build bots won't show any failure because the problem is a test failure, not a build breakage.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93957/new/

https://reviews.llvm.org/D93957



More information about the llvm-commits mailing list