[PATCH] D91255: [AArch64] Rearrange mul(dup(sext/zext)) to mul(sext/zext(dup))

[Nicholas Guy via Phabricator via llvm-commits]

NickGuy added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:11633
+
+  SDValue InsertVectorElt = VectorShuffle.getOperand(0);
+  SDValue Extend = InsertVectorElt.getOperand(1);
----------------
dmgreen wrote:
> This doesn't seem to be checking that the shuffle/insert are actually a splat.
> 
> There is an isSplatValue method that could help, depending on if it's really checking what this wants to check.
Done, though I wasn't able to produce IR that represented a shuffle/insert that wasn't a splat, so I haven't got any tests for this case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91255/new/

https://reviews.llvm.org/D91255