[PATCH] D88389: [M68k] (Patch 3/8) Basic infrastructures and target description files

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/M68k/M68kInstrFormats.td:93
+/// bit a     - use alternative, used to select index register or
+///             outer dispacement/immediate
+/// suffix NP means non-padded
----------------
dispacement -> displacement


================
Comment at: llvm/lib/Target/M68k/M68kInstrFormats.td:179
+///
+/// If the EA is a direct register use the 3 bit is known to distinguish
+/// between Data and Address register types and bits 5 and 4 are 0. This allows
----------------
"use the 3 bit is known" doesn't make sense to me. I'm not sure what's it supposed to say. "the 3 bits are known"? Or something else?


================
Comment at: llvm/lib/Target/M68k/M68kInstrFormats.td:200
+
+// NOTE: freaking tablegen...
+def MxEncEAr_0: MxEncEA<MxBeadDAReg<0>, MxBead2Bits<0b00>>;
----------------
This comment should be removed or explain what problem tablegen is causing otherwise its useless.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88389/new/

https://reviews.llvm.org/D88389