[PATCH] D88391: [M68k] (Patch 5/8) Target lowering

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 30 12:57:25 PST 2020


jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/M68k/M68kISelLowering.h:82
+
+  GlobalBaseReg,
+
----------------
myhsu wrote:
> jrtc27 wrote:
> > Change of naming style
> Well...since X86 has the same naming style for `GlobalBaseReg`, I'm incline not to change it to be in consistent with X86
X86 may be good for seeing what's possible and how to do things, but it's one of the worse backends to look at for style due to its complexity and age.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88391/new/

https://reviews.llvm.org/D88391



More information about the llvm-commits mailing list