[PATCH] D93911: [TableGen] Add the assert statement, step 1

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 30 11:17:32 PST 2020


craig.topper added inline comments.


================
Comment at: llvm/include/llvm/TableGen/Record.h:1570
+  void addAssertion(SMLoc Loc, Init *Condition, Init *Message) {
+    Assertions.push_back(std::make_tuple(Loc, Condition, Message));
+  }
----------------
Paul-C-Anagnostopoulos wrote:
> Do I need to use std::move() here?
> Do I need to use std::move() here?

I don't think so. All of individual types are cheap to copy so it should be fine to just copy the tuple.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93911/new/

https://reviews.llvm.org/D93911



More information about the llvm-commits mailing list