[PATCH] D93923: Use unary CreateShuffleVector if possible

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

See inline comments to avoid bot failures - otherwise, LGTM. Thanks for the cleanup!



================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:3193
     IRBuilder<> IRB(&I);
     Type *ShadowTy = getShadowTy(&I);
     unsigned Width =
----------------
ShadowTy is now an unused variable. Delete to avoid a compile warning.


================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:337
       Value *Vec = isColumnMajor() ? getColumn(J) : getRow(I);
       Value *Undef = UndefValue::get(Vec->getType());
       return Builder.CreateShuffleVector(
----------------
`Undef` is now an unused variable. Delete to avoid a compile warning.


================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:450
     SmallVector<Value *, 16> SplitVecs;
     Value *Undef = UndefValue::get(VType);
     for (unsigned MaskStart = 0;
----------------
Undef is now an unused variable. Delete to avoid a compile warning.


================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:944
 
     Value *Undef = UndefValue::get(Block->getType());
     Block = Builder.CreateShuffleVector(
----------------
Undef is now an unused variable. Delete to avoid a compile warning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93923/new/

https://reviews.llvm.org/D93923