[PATCH] D93891: [DAGCombine] Respect the unsafe-fp-math when perform the transformation of fpow()

[Qing Shan Zhang via Phabricator via llvm-commits]

steven.zhang added a comment.

In D93891#2473825 <https://reviews.llvm.org/D93891#2473825>, @spatel wrote:

> We're trying to (very slowly...) move away from needing the global/target options. Also, I'm not sure how those translate with GlobalISel.
> If there's a real-world case where the target options do not match the fast-math-flags on the IR, we should investigate if that was unexpected. Otherwise, I would prefer that we not add to the uses of target options.

Hmm, do you know the specific reason that it is removed so slowly ... (What I imagine is just removing it and update some tests. Some targets still want it ?) It is not right to me that it is handled inconsistent. i.e.
FPOW didn't check the unsafe-fp-math while SQRT check it.

As the direction is to remove this option, I tried to remove the unsafe-fp-math for sqrt to make the check for afn consistent in LLVM. I could do more but I am afraid I miss some background that stop this removal ...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93891/new/

https://reviews.llvm.org/D93891