[PATCH] D83305: [ADT] Fix join_impl using the wrong size when calculating total length
Nathan James via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 29 15:14:46 PST 2020
njames93 added a comment.
In D83305#2474378 <https://reviews.llvm.org/D83305#2474378>, @dblaikie wrote:
> Any chance of testing this? Could test the 'capacity' after join to check its the right size?
How do you suppose I do that, maybe expensive checks to get the capacity after reserve and after all items have been added and ensure they are the same, otherwise the string grew during appending.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83305/new/
https://reviews.llvm.org/D83305
More information about the llvm-commits
mailing list